RFR: 8347273: C2: VerifyIterativeGVN for Ideal and Identity [v3]

[Emanuel Peter]

On Tue, 10 Jun 2025 11:48:31 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> src/hotspot/share/opto/phaseX.cpp line 1126:
>> 
>>> 1124:     node->dump();
>>> 1125:   }
>>> 1126:   assert(_worklist.size() == 0, "igvn worklist must still be empty after verify");
>> 
>> The `_worklist` size does not seem to change after the bailout on L1114. So, we know that here the worklist is non-empty. Would `assert(false)` fit better?
>
> @chhagedorn While `assert(false)` would be correct, I think the check is a bit more expressive, that is why I left it in. But I guess the comment also says the same. Let me know what you prefer, I'm undecided.

Boah, I'll just change it. I don't care and that way we don't have to discuss it ;)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22970#discussion_r2137695070