RFR: 8347273: C2: VerifyIterativeGVN for Ideal and Identity [v3]

[Christian Hagedorn]

On Tue, 10 Jun 2025 11:57:11 GMT, Emanuel Peter <epeter at openjdk.org> wrote:

>> @chhagedorn While `assert(false)` would be correct, I think the check is a bit more expressive, that is why I left it in. But I guess the comment also says the same. Let me know what you prefer, I'm undecided.
>
> Boah, I'll just change it. I don't care and that way we don't have to discuss it ;)

If you don't agree and the code is not wrong, I leave it up to you to decide for these subjective suggestions. I think what made me add the suggestion was that the assert in the end suggested that there is some logic that tries to empty the list between the bailout and the assert which was not the case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22970#discussion_r2137826499