RFR: 8359227: Code cache/heap size options should be size_t [v2]

Kim Barrett kbarrett at openjdk.org
Sat Jun 14 11:10:34 UTC 2025


On Sat, 14 Jun 2025 00:53:18 GMT, SendaoYan <syan at openjdk.org> wrote:

>> Kim Barrett has updated the pull request incrementally with two additional commits since the last revision:
>> 
>>  - update copyrights
>>  - remove leftover <type_traits> include
>
> test/lib-test/jdk/test/whitebox/vm_flags/UintxTest.java line 40:
> 
>> 38: public class UintxTest {
>> 39:     private static final String FLAG_NAME = "VerifyGCStartAt";
>> 40:     private static final String FLAG_DEBUG_NAME = "StopInterpreterAt";
> 
> Hi, Does this change is a mistake. Why do we change the `FLAG_DEBUG_NAME`

Because CodeCacheMinimumUseSpace is no longer uintx-typed, it's now size_t. So the test needs to use
some other uintx-typed option.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25791#discussion_r2146426018


More information about the hotspot-dev mailing list