RFR: 8344165: Trace exceptions with a complete call-stack [v10]
Ioi Lam
iklam at openjdk.org
Tue Jun 24 04:50:02 UTC 2025
On Mon, 23 Jun 2025 12:26:13 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> src/hotspot/share/utilities/exceptions.cpp line 637:
>>
>>> 635: if (!method->is_native() && (Bytecodes::Code) *method->bcp_from(bci) == Bytecodes::_athrow) {
>>> 636: // TODO: it would be nice to filter out exceptions re-thrown by finally blocks (which include
>>> 637: // try-with-resource statements):
>>
>> This mega-comment really doesn't belong here. Please ensure this discussion is in JBS and just use a short comment here e.g.
>>
>> // TODO: try to find a way to avoid repeated stacktraces when an exception gets re-thrown by a finally block
>
> Thank you - I made this comment to Ioi privately and would really like to see it removed.
I removed the long comment and used David's suggestion instead.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25522#discussion_r2162950819
More information about the hotspot-dev
mailing list