RFR: 8346916: [REDO] align_up has potential overflow [v8]

Casper Norrbin cnorrbin at openjdk.org
Wed Mar 5 21:26:08 UTC 2025


On Wed, 5 Mar 2025 19:50:51 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Casper Norrbin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   changed psoldgen check back to earlier version
>
> src/hotspot/share/utilities/align.hpp line 80:
> 
>> 78: 
>> 79: template <typename T, typename A>
>> 80: inline bool can_align_up(T* ptr, A alignment) {
> 
> Maybe this should be later in the file, near the other pointer variants?
> Also, there's no need to parameterize the pointer type - just void* suffices.

Moved it down just above the pointer-`align_up`, and removed the pointer template.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23711#discussion_r1982203597


More information about the hotspot-dev mailing list