RFR: 8294954: Remove superfluous ResourceMarks when using LogStream
Casper Norrbin
cnorrbin at openjdk.org
Tue Mar 25 11:01:46 UTC 2025
On Mon, 24 Mar 2025 06:28:57 GMT, David Holmes <dholmes at openjdk.org> wrote:
> Did you determine that the deleted RM's were put in to be used by the LogStream rather than the things being printed to the LogStream? It is quite difficult to be sure you have exercised all of the logging code that was modified. It is quite likely many of these log outputs are not actually being tested anywhere (and very difficult to verify one way or another). Have you tested by enabling all logging in some simple tests on all platforms? (Of course that is nowhere near sufficient in terms of coverage as you would need to test with numerous permutations of VM features.)
>
> Thanks
These RMs were specifically for LogStream usage only. I left other cases untouched where they were needed for the printed content (`as_klass_external_name` is frequent) or other surrounding code.
For testing, I've also run low-tier tests with `-Xlog:all=trace`, and kept some long-running Java programs with full logging enabled. The platform-specific code immediately goes into shared implementations, so exhaustive platform-specific testing shouldn't be necessary.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24162#issuecomment-2750876047
More information about the hotspot-dev
mailing list