RFR: 8294954: Remove superfluous ResourceMarks when using LogStream

[David Holmes]

On Fri, 21 Mar 2025 15:38:21 GMT, Casper Norrbin <cnorrbin at openjdk.org> wrote:

> Hi everyone,
> 
> This PR removes redundant `ResourceMark` instances where `LogStream` is used. Previously, `LogStream` inherited from `ResourceObj`, which required a `ResourceMark`, but this is no longer the case, making these instances unnecessary.
> 
> Process:
> 1. I added assertions to check for resource unwinding in places where `ResourceMark`s were used with `LogStream`s.
> 2. Ran tests up to tier7 to confirm no unwinding was happening. This helped filter out cases where `ResourceMark`s were still required for other reasons.
> 3. Manually verified the remaining cases by tracing function calls to ensure the `ResourceMark`s were truly unnecessary.
> 4. Removed the redundant `ResourceMark` instances.

Thanks for the additional info @caspernorrbin . Looks good.

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24162#pullrequestreview-2715740332