RFR: 8352579: Refactor CDS legacy optimization for lambda proxy classes [v4]

[Calvin Cheung]

On Fri, 21 Mar 2025 23:47:46 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Since JDK 16, CDS has provided limited optimization for lambda expressions. This has been superseded by JEP 483 and is useful only when `-XX:+AOTClassLinking` is not enabled (which is the case for the default CDS archive, for compatibility reasons).
>> 
>> The "legacy lambda optimization" may eventually be removed. For the time being, we should consolidate the code into a single source code and clearly mark its uses. This way we can avoid confusion with the JEP 483 code for supporting lambdas (and other java.lang.invoke functionalities).
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   @matias9927 offline comments - consolidated two functions with identical names

Spotted couple of extra include statements. Looks good.

src/hotspot/share/cds/lambdaProxyClassDictionary.cpp line 31:

> 29: #include "classfile/systemDictionaryShared.hpp"
> 30: #include "interpreter/bootstrapInfo.hpp"
> 31: #include "jfr/jfrEvents.hpp"

Extra include?

src/hotspot/share/classfile/systemDictionaryShared.cpp line 34:

> 32: #include "cds/classListWriter.hpp"
> 33: #include "cds/dumpTimeClassInfo.inline.hpp"
> 34: #include "cds/dynamicArchive.hpp"

Pre-existing: I think the include of `cds/archiveHeapLoader.hpp` at line #27 is unnecessary.

-------------

Marked as reviewed by ccheung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24145#pullrequestreview-2715327433
PR Review Comment: https://git.openjdk.org/jdk/pull/24145#discussion_r2013010453
PR Review Comment: https://git.openjdk.org/jdk/pull/24145#discussion_r2013014309