RFR: 8352579: Refactor CDS legacy optimization for lambda proxy classes [v4]

Ioi Lam iklam at openjdk.org
Wed Mar 26 22:11:49 UTC 2025


On Tue, 25 Mar 2025 22:13:55 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   @matias9927 offline comments - consolidated two functions with identical names
>
> src/hotspot/share/cds/lambdaProxyClassDictionary.cpp line 31:
> 
>> 29: #include "classfile/systemDictionaryShared.hpp"
>> 30: #include "interpreter/bootstrapInfo.hpp"
>> 31: #include "jfr/jfrEvents.hpp"
> 
> Extra include at line 31?

jfrEvents.hpp is needed by `EventClassLoad` on line 360

> src/hotspot/share/classfile/systemDictionaryShared.cpp line 34:
> 
>> 32: #include "cds/classListWriter.hpp"
>> 33: #include "cds/dumpTimeClassInfo.inline.hpp"
>> 34: #include "cds/dynamicArchive.hpp"
> 
> Pre-existing: I think the include of `cds/archiveHeapLoader.hpp` at line #27 is unnecessary.

Removed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24145#discussion_r2015063220
PR Review Comment: https://git.openjdk.org/jdk/pull/24145#discussion_r2015063251


More information about the hotspot-dev mailing list