RFR: 8352645: Add tool support to check order of includes [v2]

[Stefan Karlsson]

On Thu, 27 Mar 2025 09:04:45 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Since there are no such cases in the files processed in this PR, I'd suggest not adding support for them. They can be fixed in follow up PRs as the relevant directories are added to `TestIncludesAreSorted.HOTSPOT_SOURCES_TO_CHECK`.
>
> The regex needs to detect that case eventually anyway, so I think it should be done now.  Either we allow that
> case, in which case the regex must match to work properly where they are present.  Or we forbid that case,
> in which case the regex must match to detect future mistakes even after we've cleaned up existing usage.

To me it seems like a small adjustment fixes this
Suggestion:

    private static final String INCLUDE_LINE = "^ *# *include *(<[^>]+>|"[^"]+") *$\\n";

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24247#discussion_r2016040674