RFR: 8352645: Add tool support to check order of includes [v2]

Doug Simon dnsimon at openjdk.org
Thu Mar 27 09:49:38 UTC 2025


On Thu, 27 Mar 2025 09:20:58 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> The regex needs to detect that case eventually anyway, so I think it should be done now.  Either we allow that
>> case, in which case the regex must match to work properly where they are present.  Or we forbid that case,
>> in which case the regex must match to detect future mistakes even after we've cleaned up existing usage.
>
> To me it seems like a small adjustment fixes this
> Suggestion:
> 
>     private static final String INCLUDE_LINE = "^ *# *include *(<[^>]+>|"[^"]+") *$\\n";

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24247#discussion_r2016091219


More information about the hotspot-dev mailing list