RFR: 8353129: CDS ArchiveRelocation tests fail after JDK-8325132

[David Holmes]

On Sat, 29 Mar 2025 02:47:53 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> Two archive relocation tests failed when `-XX:ArchiveRelocationMode=0` is specified via the jtreg `-javaoption`.
> A fix is to add a `WhiteBox.getArchiveRelocationMode()` method so that the tests can check if the `ArchiveRelocationMode` is set to 0 before checking the expected output.
> 
> Passed tiers 1 - 4 testing.

I think these tests are very confusing!

test/hotspot/jtreg/runtime/cds/appcds/ArchiveRelocationTest.java

States

> @comment the test uses -XX:ArchiveRelocationMode=1 to force relocation.

but that is not what it does. It either sets -`XX:ArchiveRelocationMode=0` in the exec'd VM or it relies on the default being 1 - which is not the case if it was set directly via JTREG. So it seems to me the right, and simple, fix here is to always pass the expected  `-XX:ArchiveRelocationMode` value to the exec'd VM and ignore/override whatever comes in via the command-line.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24308#issuecomment-2764860687