RFR: 8356027: Print enhanced compilation timings [v2]

Aleksey Shipilev shade at openjdk.org
Mon May 5 16:04:47 UTC 2025


On Fri, 2 May 2025 16:18:23 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test TestDuplicatedLateInliningOutput.java
>
> src/hotspot/share/compiler/compileBroker.cpp line 2354:
> 
>> 2352:     task->mark_finished(os::elapsed_counter());
>> 2353: 
>> 2354:     if (failure_reason != nullptr) {
> 
> I see this code has been moved into the block that handles the case when JVMCI is not used. Earlier this code was executed unconditionally. Is this code not applicable for JVMCI case now?

I moved this code because we need access to `ciEnv` to get access to inline messages. Their lifecycle also depend on `ciEnv` lifecycle. But you are right, JVMCI does not get here now, which is not what I intended. I'll see what can be done here.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24984#discussion_r2073724644


More information about the hotspot-dev mailing list