RFR: 8356027: Print enhanced compilation timings [v2]

Aleksey Shipilev shade at openjdk.org
Mon May 5 16:37:00 UTC 2025


On Mon, 5 May 2025 16:00:42 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

>> src/hotspot/share/compiler/compileBroker.cpp line 2354:
>> 
>>> 2352:     task->mark_finished(os::elapsed_counter());
>>> 2353: 
>>> 2354:     if (failure_reason != nullptr) {
>> 
>> I see this code has been moved into the block that handles the case when JVMCI is not used. Earlier this code was executed unconditionally. Is this code not applicable for JVMCI case now?
>
> I moved this code because we need access to `ciEnv` to get access to inline messages. Their lifecycle also depend on `ciEnv` lifecycle. But you are right, JVMCI does not get here now, which is not what I intended. I'll see what can be done here.

Done. We have to pay with one additional copy, which we _can_ optimize if we really wanted, but I don't think we care as much, since this only matters when `-XX:+PrintInlining` is enabled.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24984#discussion_r2073781217


More information about the hotspot-dev mailing list