RFR: 8317453: NMT: Performance benchmarks are needed to measure speed and memory [v15]

Gerard Ziemski gziemski at openjdk.org
Thu May 8 14:38:55 UTC 2025


On Thu, 8 May 2025 06:58:43 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Johan feedback, remove unused parameter
>
> src/hotspot/share/nmt/memLogRecorder.hpp line 94:
> 
>> 92: 
>> 93: private:
>> 94:     struct Entry {
> 
> wrong indentation, and also pull out the common stuff from the two `Entry` structs we have into a superclass.

Done, except the indentation. How should it look?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23786#discussion_r2079850319


More information about the hotspot-dev mailing list