RFR: 8317453: NMT: Performance benchmarks are needed to measure speed and memory [v15]
Gerard Ziemski
gziemski at openjdk.org
Thu May 8 14:47:50 UTC 2025
On Thu, 8 May 2025 07:07:10 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:
>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Johan feedback, remove unused parameter
>
> src/hotspot/share/nmt/memLogRecorder.cpp line 93:
>
>> 91:
>> 92:
>> 93: #define NMT_HEADER_SIZE 16
>
> Do not use `#define` for the constant, use a static const, and don't put it in as a magic number but find it out from a `sizeof` on the appropriate type.
Done.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23786#discussion_r2079864345
More information about the hotspot-dev
mailing list