RFR: 8356372: JVMTI heap sampling not working properly with outside TLAB allocations [v3]

Serguei Spitsyn sspitsyn at openjdk.org
Mon May 19 09:36:52 UTC 2025


On Fri, 16 May 2025 18:41:11 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> Stefan Karlsson has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Apply suggestions from code review
>>   
>>   Co-authored-by: Stefan Johansson <54407259+kstefanj at users.noreply.github.com>
>
> src/hotspot/share/runtime/threadHeapSampler.hpp line 89:
> 
>> 87: 
>> 88:     // Call this after _rnd is initialized to initialize _bytes_until_sample.
>> 89:     pick_next_sample();
> 
> The old identifier is used: _bytes_until_sample.

This comment still need a fix as this name was removed by this fix.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25114#discussion_r2095287505


More information about the hotspot-dev mailing list