RFR: 8356372: JVMTI heap sampling not working properly with outside TLAB allocations [v3]

Stefan Karlsson stefank at openjdk.org
Mon May 19 11:40:08 UTC 2025


On Mon, 19 May 2025 09:34:26 GMT, Serguei Spitsyn <sspitsyn at openjdk.org> wrote:

>> src/hotspot/share/runtime/threadHeapSampler.hpp line 89:
>> 
>>> 87: 
>>> 88:     // Call this after _rnd is initialized to initialize _bytes_until_sample.
>>> 89:     pick_next_sample();
>> 
>> The old identifier is used: _bytes_until_sample.
>
> The comment at line 89 still need a tweak as the name `_bytes_until_sample` is being removed by this fix.

Thanks! I've now updated the comment.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25114#discussion_r2095510797


More information about the hotspot-dev mailing list