RFR: 8357220: Introduce a BSMAttributeEntry struct

Chris Plummer cjplummer at openjdk.org
Tue May 20 20:26:54 UTC 2025


On Tue, 20 May 2025 06:34:20 GMT, Johan Sjölen <jsjolen at openjdk.org> wrote:

>> src/jdk.hotspot.agent/share/classes/sun/jvm/hotspot/oops/ConstantPool.java line 126:
>> 
>>> 124:   private static int INDY_BSM_OFFSET = 0;
>>> 125:   private static int INDY_ARGC_OFFSET = 1;
>>> 126:   private static int INDY_ARGV_OFFSET = 2;
>> 
>> Is the SA code that references these fields still correct? It seems the references are from the ClassWriter, which we don't have very good test coverage for. Probably this is a bug that is not being detected.
>
> The references are still correct, as we haven't changed the struct layout. We're also not planning on doing so. I don't think that there is a bug here.

Ok. It's just unusual to see constants like these that are needed by SA but serve no purpose in hotspot.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25298#discussion_r2098809598


More information about the hotspot-dev mailing list