RFR: 8357220: Introduce a BSMAttributeEntry struct [v2]

[Coleen Phillimore]

On Tue, 20 May 2025 20:24:25 GMT, Chris Plummer <cjplummer at openjdk.org> wrote:

>> The references are still correct, as we haven't changed the struct layout. We're also not planning on doing so. I don't think that there is a bug here.
>
> Ok. It's just unusual to see constants like these that are needed by SA but serve no purpose in hotspot.

It does seem like you want to mirror these constants from the vmStructs side like it was rather than defining them here in the SA.  I see why you did this but maybe you can add the constants to BSMAttributeEntry and declare them constants using declare_constant(BSMAttributeEntry::_indy...).
In case you change them.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25298#discussion_r2113771428