RFR: 8357626: RISCV: Tighten up template interpreter method entry code [v3]

Fei Yang fyang at openjdk.org
Wed May 28 07:49:53 UTC 2025


On Wed, 28 May 2025 03:25:09 GMT, Anjian Wen <wenanjian at openjdk.org> wrote:

>> do the same thing as x86/AArch64 but for RISCV
>> [JDK-8352415](https://bugs.openjdk.org/browse/JDK-8352415) 
>> [JDK-8356949](https://bugs.openjdk.org/browse/JDK-8356949)
>
> Anjian Wen has updated the pull request incrementally with one additional commit since the last revision:
> 
>   add comments

src/hotspot/cpu/riscv/templateInterpreterGenerator_riscv.cpp line 806:

> 804: 
> 805:   // Save ConstantPool* in t3_constants for later use to avoid loading multiple times
> 806:   Register t3_constants = t3;

Can you rename this as `x28_constants`? Like: `Register x28_constants = x28;`

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25412#discussion_r2111178235


More information about the hotspot-dev mailing list