RFR: 8370254: Add VM_MEMORY_JAVA mmap tag to MacOS mmap calls [v3]
Stefan Karlsson
stefank at openjdk.org
Tue Nov 4 17:06:52 UTC 2025
On Tue, 4 Nov 2025 16:46:28 GMT, Nityanand Rai <duke at openjdk.org> wrote:
>> Add VM_MEMORY_JAVA tag to mmap calls in os_bsd.cpp for better memory tracking of java process on macOs
>
> Nityanand Rai has updated the pull request incrementally with one additional commit since the last revision:
>
> clean whitespaces
EOD here but got notified about this change. A few quick comments:
1) Could you fix the whitespace issues GH is complaining about?
2) There's a significant amount of duplication of these conspicuous additions. Could you you create a constexpr function and use that instead?
3) It doesn't seem prudent to put the new testing code in our test_zForwarding.cpp file. Could this be in its own test file?
-------------
Changes requested by stefank (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27868#pullrequestreview-3417654140
More information about the hotspot-dev
mailing list