RFR: 8370254: Add VM_MEMORY_JAVA mmap tag to MacOS mmap calls [v3]

Nityanand Rai duke at openjdk.org
Tue Nov 4 19:07:33 UTC 2025


On Tue, 4 Nov 2025 17:03:56 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> EOD here but got notified about this change. A few quick comments:
> 
> 1. Could you fix the whitespace issues GH is complaining about?
Fixed
> 2. There's a significant amount of duplication of these conspicuous additions. Could you you create a constexpr function and use that instead?
Refactored code to remove duplication.
> 3. It doesn't seem prudent to put the new testing code in our test_zForwarding.cpp file. Could this be in its own test file?
I think the changes are minor to assert the tagging on allocation while we are doing that and do not require extra tests, please let me know if you still think otherwise.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27868#issuecomment-3487603064


More information about the hotspot-dev mailing list