RFR: 8371869: RISC-V: too many warnings when build on BPI-F3 SBC [v2]

[Fei Yang]

On Tue, 18 Nov 2025 15:03:52 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Fei Yang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review
>
> src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp line 110:
> 
>> 108: }
>> 109: 
>> 110: void VM_Version::RVExtFeatureValue::log_disabled(const char* reason) {
> 
> Seems we don't need to distinguish whether `reason` is nullptr or not? as `log_disabled` is called only when it's disabled because of depenency check failure.

Make sense. Removed the nullptr check.

> src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp line 122:
> 
>> 120: }
>> 121: 
>> 122: void VM_Version::RVNonExtFeatureValue::log_disabled(const char* reason) {
> 
> Is `log_disabled` in RVNonExtFeatureValue invoked in some condition?

No. But like `virtual void log_enabled() = 0;`, `log_disabled` is also a pure virtual function in the base class. So it has to be implemented in all the subclasses.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28340#discussion_r2540438067
PR Review Comment: https://git.openjdk.org/jdk/pull/28340#discussion_r2540440309