RFR: 8371869: RISC-V: too many warnings when build on BPI-F3 SBC [v2]

Hamlin Li mli at openjdk.org
Wed Nov 19 09:49:13 UTC 2025


On Wed, 19 Nov 2025 04:00:28 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> src/hotspot/os_cpu/linux_riscv/vm_version_linux_riscv.cpp line 122:
>> 
>>> 120: }
>>> 121: 
>>> 122: void VM_Version::RVNonExtFeatureValue::log_disabled(const char* reason) {
>> 
>> Is `log_disabled` in RVNonExtFeatureValue invoked in some condition?
>
> No. But like `virtual void log_enabled() = 0;`, `log_disabled` is also a pure virtual function in the base class. So it has to be implemented in all the subclasses.

As `log_disabled` is only called in `UPDATE_DEFAULT_DEP`, which is only called in subclasses of `RVExtFeatureValue`, so I think it's OK to put `log_disabled` under `RVExtFeatureValue`?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28340#discussion_r2541284249


More information about the hotspot-dev mailing list