RFR: 8371869: RISC-V: too many warnings when build on BPI-F3 SBC [v3]
Fei Yang
fyang at openjdk.org
Thu Nov 20 11:19:33 UTC 2025
On Wed, 19 Nov 2025 09:47:11 GMT, Hamlin Li <mli at openjdk.org> wrote:
>> No. But like `virtual void log_enabled() = 0;`, `log_disabled` is also a pure virtual function in the base class. So it has to be implemented in all the subclasses.
>
> As `log_disabled` is only called in `UPDATE_DEFAULT_DEP`, which is only called in subclasses of `RVExtFeatureValue`, so I think it's OK to put `log_disabled` under `RVExtFeatureValue`?
That also works for me. Check the latest version.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28340#discussion_r2545563008
More information about the hotspot-dev
mailing list