RFR: 8357445: G1: Time-Based Heap Uncommit During Idle Periods [v2]
Thomas Schatzl
tschatzl at openjdk.org
Thu Nov 20 15:09:00 UTC 2025
On Wed, 16 Jul 2025 22:00:14 GMT, Monica Beckwith <mbeckwit at openjdk.org> wrote:
>> src/hotspot/share/gc/g1/g1HeapEvaluationTask.cpp line 36:
>>
>>> 34: #include "utilities/globalDefinitions.hpp"
>>> 35:
>>> 36: G1HeapEvaluationTask::G1HeapEvaluationTask(G1CollectedHeap* g1h, G1HeapSizingPolicy* heap_sizing_policy) :
>>
>> `G1HeapEvaluationTask` class name does not seem to clearly state the purpose of the class. But I cannot come up with a better name.
>
> I can see that while 'G1HeapEvaluationTask' is generic, it kind of does describe what the class does (evaluates heap sizing decisions). The time-based nature is captured in the feature flag and comments. Open to suggestions if you have a preference.
Maybe `ReEvaluateHeapSizeTask` or something that gives more information about the purpose.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26240#discussion_r2546048603
More information about the hotspot-dev
mailing list