RFR: 8357445: G1: Time-Based Heap Uncommit During Idle Periods [v10]
Thomas Schatzl
tschatzl at openjdk.org
Thu Nov 20 15:09:10 UTC 2025
On Thu, 20 Nov 2025 14:57:34 GMT, Thomas Schatzl <tschatzl at openjdk.org> wrote:
>> src/hotspot/share/gc/g1/g1HeapSizingPolicy.cpp line 535:
>>
>>> 533:
>>> 534: // Only count if region is ready for shrinking
>>> 535: if (hr->is_empty() && hr->is_free()) {
>>
>> `is_empty()` is wrong, already mentioned this in the last review.
>
> All free regions are empty.
The whole method seems unnecessary. All candidates passed are valid candidates since the `is_free()` check should have already occurred (and it did).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26240#discussion_r2546414536
More information about the hotspot-dev
mailing list