RFR: 8366716: Move SmapsParser from runtime/os/TestTracePageSizes.java into testlib [v3]

[Stefan Johansson]

On Sun, 5 Oct 2025 13:34:53 GMT, jonghoonpark <duke at openjdk.org> wrote:

>> Found some time to look closer at this. I would prefer if we could clean up the `Smaps` class even more when moving it to the testlib. We might want to go even further than this:
>> https://github.com/openjdk/jdk/compare/master...kstefanj:jdk:pull/27273-v2
>> 
>> I felt it was easier to show you my ideas this way rather than just giving comment. Some names might need improving and some more polishing, but what do you think about the general structure [here](https://github.com/openjdk/jdk/commit/4550eb677d74803935be64a1cc321c671f91adc7)?
>
> @kstefanj  
> Sorry for the late reply.
> 
> I’ve reviewed the code you wrote, and I think it’s much clearer!
> I’ve updated it with your suggested changes and confirmed that everything works fine in testing.
> 
> //
> 
> Sorry for rebasing — it’s a habit of mine, and I did it without thinking. I’ll be more careful next time.

@dev-jonghoonpark, thanks for addressing my concerns.

I need to look over it again but I'm traveling this week and will have less time than normal for reviews. I'll see if I can find some time, otherwise I will look at this next week.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27273#issuecomment-3373496756