RFR: 8366716: Move SmapsParser from runtime/os/TestTracePageSizes.java into testlib [v3]

jonghoonpark duke at openjdk.org
Sun Oct 5 13:37:46 UTC 2025


On Wed, 17 Sep 2025 16:45:01 GMT, Stefan Johansson <sjohanss at openjdk.org> wrote:

>> jonghoonpark has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>> 
>>   Refactor: Introduce Smaps class for testing
>>   
>>   Signed-off-by: jonghoonpark <dev at jonghoonpark.com>
>
> Found some time to look closer at this. I would prefer if we could clean up the `Smaps` class even more when moving it to the testlib. We might want to go even further than this:
> https://github.com/openjdk/jdk/compare/master...kstefanj:jdk:pull/27273-v2
> 
> I felt it was easier to show you my ideas this way rather than just giving comment. Some names might need improving and some more polishing, but what do you think about the general structure [here](https://github.com/openjdk/jdk/commit/4550eb677d74803935be64a1cc321c671f91adc7)?

@kstefanj  
Sorry for the late reply.

I’ve reviewed the code you wrote, and I think it’s much clearer!
I’ve updated it with your suggested changes and confirmed that everything works fine in testing.

//

Sorry for rebasing — it’s a habit of mine, and I did it without thinking. I’ll be more careful next time.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/27273#issuecomment-3369062974


More information about the hotspot-dev mailing list