RFR: 8369190: JavaFrameAnchor on AArch64 has unnecessary barriers and wrong store order in MacroAssembler [v4]
Andrew Haley
aph at openjdk.org
Mon Oct 6 19:45:47 UTC 2025
On Mon, 6 Oct 2025 16:43:42 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Justin King has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add comment to JavaFrameAnchor regarding no need for fencing
>>
>> Signed-off-by: Justin King <jcking at google.com>
>
> src/hotspot/cpu/aarch64/javaFrameAnchor_aarch64.hpp line 44:
>
>> 42: // clearing _last_Java_sp must be first
>> 43: _last_Java_sp = nullptr;
>> 44: OrderAccess::release();
>
> You still need a compiler fence here.
Maybe not, if this is the same thread as readers. I don't know what it's for.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27645#discussion_r2408194924
More information about the hotspot-dev
mailing list