RFR: 8368897: RISC-V: Cleanup RV_EXT_FEATURE_FLAGS & RV_NON_EXT_FEATURE_FLAGS [v5]

[Fei Yang]

On Thu, 9 Oct 2025 08:37:35 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Hi,
>> Can you help to review the patch?
>> 
>> This patch cleans up RV_EXT_FEATURE_FLAGS & RV_NON_EXT_FEATURE_FLAGS, as discussed https://github.com/openjdk/jdk/pull/27152#discussion_r2367109820:
>> * reorder flags in alphabetic order for RV_EXT_FEATURE_FLAGS
>> * move comments close to feature declaration for RV_EXT_FEATURE_FLAGS & RV_NON_EXT_FEATURE_FLAGS
>> 
>> We also discussed (https://github.com/openjdk/jdk/pull/27171#discussion_r2387195562) the assert introduced in https://github.com/openjdk/jdk/pull/24094, previously we think this will restrict the flags order in RV_EXT_FEATURE_FLAGS, but I found out that this  assert (<del>is not necessary</del>, so we should be able to order flags in RV_EXT_FEATURE_FLAGS in any way we'd like to) does not work as expected, will fix this in another pr.
>> 
>> Thanks!
>
> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
> 
>   revert name from non_ext_xxx

src/hotspot/cpu/riscv/vm_version_riscv.hpp line 293:

> 291:   /* Manufactory JEDEC id encoded, ISA vol 2 3.1.2.. */                                        \
> 292:   decl(mvendorid        ,  RV_NO_FLAG_BIT,  false,  NO_UPDATE_DEFAULT)                         \
> 293:   decl(zicboz_block_size ,  RV_NO_FLAG_BIT,  false,  NO_UPDATE_DEFAULT)                        \

You might want to fix the style for this group making the `,` separator at the same column. LGTM otherwise.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27562#discussion_r2418333461