RFR: 8368897: RISC-V: Cleanup RV_EXT_FEATURE_FLAGS & RV_NON_EXT_FEATURE_FLAGS [v5]

Hamlin Li mli at openjdk.org
Fri Oct 10 08:17:46 UTC 2025


On Fri, 10 Oct 2025 02:01:55 GMT, Fei Yang <fyang at openjdk.org> wrote:

>> Hamlin Li has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   revert name from non_ext_xxx
>
> src/hotspot/cpu/riscv/vm_version_riscv.hpp line 293:
> 
>> 291:   /* Manufactory JEDEC id encoded, ISA vol 2 3.1.2.. */                                        \
>> 292:   decl(mvendorid        ,  RV_NO_FLAG_BIT,  false,  NO_UPDATE_DEFAULT)                         \
>> 293:   decl(zicboz_block_size ,  RV_NO_FLAG_BIT,  false,  NO_UPDATE_DEFAULT)                        \
> 
> You might want to fix the style for this group making the `,` separator at the same column. LGTM otherwise.

fixed!

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27562#discussion_r2418870283


More information about the hotspot-dev mailing list