RFR: 8366716: Move SmapsParser from runtime/os/TestTracePageSizes.java into testlib [v4]
Stefan Johansson
sjohanss at openjdk.org
Mon Oct 13 10:30:15 UTC 2025
On Sun, 5 Oct 2025 13:30:27 GMT, jonghoonpark <duke at openjdk.org> wrote:
>> related jira issue: https://bugs.openjdk.org/browse/JDK-8366716
>>
>> ---
>>
>> Following the direction outlined in the issue description,
>> I've extracted the common parts from `TestTracePageSizes` and `TestTransparentHugePagesHeap` to implement the `SmapsParser` test library.
>>
>> I've confirmed that it works without issues in my local tests.
>>
>> Reviews and feedback are welcome.
>
> jonghoonpark has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision:
>
> Refactor: Introduce Smaps class for testing
>
> Signed-off-by: jonghoonpark <dev at jonghoonpark.com>
Now I've had time to look through this and more or less nothing more to add, just a small update to one comment.
Did run some additional testing as well, which looked good.
Please also add me ass co-author since we now have collaborated on the change, just use the commands:
test/lib/jdk/test/lib/os/linux/Smaps.java line 167:
> 165: // ...
> 166: // KernelPageSize: 4 kB
> 167: // ...
Suggestion:
// ...
// THPeligible: 0
// ...
Pre-existing, but we should update the comment to include that we also care about THPeligible.
-------------
Changes requested by sjohanss (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27273#pullrequestreview-3330863912
PR Review Comment: https://git.openjdk.org/jdk/pull/27273#discussion_r2425841317
More information about the hotspot-dev
mailing list