RFR: 8369616: JavaFrameAnchor on RISC-V has unnecessary barriers and wrong store order in MacroAssembler [v2]

Feilong Jiang fjiang at openjdk.org
Mon Oct 13 15:27:05 UTC 2025


On Mon, 13 Oct 2025 07:48:48 GMT, Ludovic Henry <luhenry at openjdk.org> wrote:

>> Feilong Jiang has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update comments
>
> src/hotspot/cpu/riscv/javaFrameAnchor_riscv.hpp line 43:
> 
>> 41:   void clear(void) {
>> 42:     // No hardware barriers are necessary. All members are volatile and the profiler
>> 43:     // is run from a signal handler and only observers the thread its running on.
> 
> Suggestion:
> 
>     // is run from a signal handler and the only observer is the thread its running on.

Fixed.

> src/hotspot/cpu/riscv/javaFrameAnchor_riscv.hpp line 53:
> 
>> 51:   void copy(JavaFrameAnchor* src) {
>> 52:     // No hardware barriers are necessary. All members are volatile and the profiler
>> 53:     // is run from a signal handler and only observers the thread its running on.
> 
> Suggestion:
> 
>     // is run from a signal handler and the only observer is the thread its running on.

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27757#discussion_r2426655800
PR Review Comment: https://git.openjdk.org/jdk/pull/27757#discussion_r2426656003


More information about the hotspot-dev mailing list