RFR: 8317269: Store old classes in linked state in AOT cache [v4]
Ioi Lam
iklam at openjdk.org
Mon Sep 1 01:01:38 UTC 2025
On Fri, 29 Aug 2025 18:57:23 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>>
>> - Merge branch 'master' into 8317269-store-old-classes-in-linked-state-in-aot-cache
>> - @coleenp comments
>> - More bug fixes from JCK testing
>> - Fixed bugs found in JCK testing
>> - 8317269: Store old classes in linked state in AOT cache
>
> src/hotspot/share/cds/runTimeClassInfo.hpp line 204:
>
>> 202: u4* old_verifier_dependencies() {
>> 203: assert(_num_old_verifier_dependencies > 0, "sanity");
>> 204: return (u4*)(address(this) + old_verifier_dependencies_offset());
>
> This seems like it should have a checked_cast<> around it rather than a plain cast.
`checked_cast<>` only checks size difference of the source and target types, but here both are pointer types so they have the same size.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26754#discussion_r2312711414
More information about the hotspot-dev
mailing list