RFR: 8317269: Store old classes in linked state in AOT cache [v4]
Ioi Lam
iklam at openjdk.org
Mon Sep 1 01:01:43 UTC 2025
On Fri, 29 Aug 2025 21:51:45 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> src/hotspot/share/prims/jvm.cpp line 854:
>>
>>> 852:
>>> 853: #if INCLUDE_CDS
>>> 854: if (CDSConfig::is_preserving_verification_dependencies() && from_class->is_instance_klass()) {
>>
>> It looks like from_class can be null so you have to check for null here.
>> Which doesn't make sense because the logging doesn't have null checks.
>
> This looks like something that should be cleaned up apart from this change.
"from" can never be null. I created [JDK-8366488](https://bugs.openjdk.org/browse/JDK-8366488) - "JVM_FindClassFromClass should assert that from class is never null"
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26754#discussion_r2312711385
More information about the hotspot-dev
mailing list