RFR: 8317269: Store old classes in linked state in AOT cache [v5]

[Ioi Lam]

On Fri, 29 Aug 2025 20:56:25 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> src/hotspot/share/classfile/systemDictionaryShared.cpp line 1036:
>> 
>>> 1034:   DumpTimeClassInfo* info = get_info(ik);
>>> 1035:   Handle loader(current, ik->class_loader());
>>> 1036:   Klass* k = SystemDictionary::find_instance_or_array_klass(current, name, loader);
>> 
>> The caller just did this, didn't it?  So, you should just be able to pass in from_class (unless it's null).
>
> I would kind of prefer old_verifier_dependency rather than old_verification - the latter seems to say that we had some verification that is no longer valid.  old_verifier makes it clearer it's for old classfiles and the old verifier.  Also 'verification' is used for the regular verifier so it's less of a same name.

> The caller just did this, didn't it?

There is a different caller (SystemDictionaryShared::copy_verification_info_from_preimage) which has only the class name.

> I would kind of prefer old_verifier_dependency
 
The current code is kind of messy. For example, we have _verifier_constraints in DumpTimeClassInfo, but other places use "verification_constraints".

Maybe I should rename all old and new cases of verification_xxx to verifier_xxx?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26754#discussion_r2312711164