RFR: 8317269: Store old classes in linked state in AOT cache [v4]

[Ioi Lam]

On Fri, 29 Aug 2025 16:36:09 GMT, Matias Saavedra Silva <matsaave at openjdk.org> wrote:

>> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>> 
>>  - Merge branch 'master' into 8317269-store-old-classes-in-linked-state-in-aot-cache
>>  - @coleenp comments
>>  - More bug fixes from JCK testing
>>  - Fixed bugs found in JCK testing
>>  - 8317269: Store old classes in linked state in AOT cache
>
> src/hotspot/share/cds/cdsConfig.cpp line 939:
> 
>> 937:   // of the production run. This means that if a class was successfully verified
>> 938:   // in the assembly phase, all of the verifier's assignability checks will remain
>> 939:   // valid in the production run, so we don't need to verify aot-lined classes again.
> 
> Type: aot-lined -> aot-linked

Fixed

> src/hotspot/share/cds/dumpTimeClassInfo.cpp line 94:
> 
>> 92:   if (log_is_enabled(Trace, aot, verification)) {
>> 93:     ResourceMark rm;
>> 94:     log_trace(aot, verification)("add old verification dependency: %s: %s must be also be archived",
> 
> Should this comment be "added old..."?

Fixed

> src/hotspot/share/classfile/systemDictionaryShared.cpp line 241:
> 
>> 239: }
>> 240: 
>> 241: // This is a table of classes that need to be check for exclusion.
> 
> Typo: check -> checked

Fixed.

> src/hotspot/share/classfile/systemDictionaryShared.cpp line 312:
> 
>> 310:   ResourceMark rm;
>> 311: 
>> 312:   // This will recursive find ik and all of its exclusion dependencies that have not yet been checked.
> 
> Typo: recursively

Fixed.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26754#discussion_r2323096950
PR Review Comment: https://git.openjdk.org/jdk/pull/26754#discussion_r2323097082
PR Review Comment: https://git.openjdk.org/jdk/pull/26754#discussion_r2323097206
PR Review Comment: https://git.openjdk.org/jdk/pull/26754#discussion_r2323097323