RFR: 8317269: Store old classes in linked state in AOT cache [v5]

[Coleen Phillimore]

On Thu, 4 Sep 2025 18:46:56 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>>> The caller just did this, didn't it?
>> 
>> There is a different caller (SystemDictionaryShared::copy_verification_info_from_preimage) which has only the class name.
>> 
>>> I would kind of prefer old_verifier_dependency
>>  
>> The current code is kind of messy. For example, we have _verifier_constraints in DumpTimeClassInfo, but other places use "verification_constraints".
>> 
>> Maybe I should rename all old and new cases of verification_xxx to verifier_xxx?
>
> That's why I'm confused, there's one in DumpTimeInfo and another one in SystemDictionaryShared.
> 
> Shouldn't this call find_{verification_dependency}_bottom_klass?  Looks like the same code.  I feel like you want to generalize this case where you try to find the underlying InstanceKlass.  And pass the class_loader rather than getting if from 'k'.   And define it in SystemDictionary under the find_instance_or_array_klass.

I think changing them to verifier rather than verification makes sense since it means the verifier not verification in general.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26754#discussion_r2323159170