RFR: 8367368: Add message for verify_legal_class_modifiers for inner classes [v5]

David Holmes dholmes at openjdk.org
Thu Sep 11 21:35:20 UTC 2025


On Thu, 11 Sep 2025 18:14:57 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This adds the inner class name (or unnamed) to the error message for invalid inner class modifiers.
>> Testing with tier1-4.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Only test for message fragments - Chen's comments.

src/hotspot/share/classfile/classFileParser.cpp line 4316:

> 4314:       );
> 4315:     } else {
> 4316:       if (is_anonymous_inner_class) {

I think you could have just defined "<anonymous>" as a default name to use here rather then explicitly passing in the parameter.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27201#discussion_r2342385187


More information about the hotspot-dev mailing list