RFR: 8367368: Add message for verify_legal_class_modifiers for inner classes [v5]

Coleen Phillimore coleenp at openjdk.org
Fri Sep 12 19:02:39 UTC 2025


On Thu, 11 Sep 2025 21:32:02 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Only test for message fragments - Chen's comments.
>
> src/hotspot/share/classfile/classFileParser.cpp line 4316:
> 
>> 4314:       );
>> 4315:     } else {
>> 4316:       if (is_anonymous_inner_class) {
> 
> I think you could have just defined "<anonymous>" as a default name to use here rather then explicitly passing in the parameter.

It wouldn't have been a better message though, or else I'd have to check for vmSymbols::null_symbol (which we don't have).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27201#discussion_r2345168927


More information about the hotspot-dev mailing list