RFR: 8367320: Sort cpu/x86 includes [v2]

Francesco Andreuzzi fandreuzzi at openjdk.org
Fri Sep 12 11:14:22 UTC 2025


On Fri, 12 Sep 2025 10:16:33 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> I think the style guide should be changed too if we want to make this change:
>> 
>> All .inline.hpp files should include their corresponding .hpp file as
>> the first include line with a blank line separating it from the rest of the
>> include lines.
>> 
>> 
>> There should be some more details about what constitutes the "corresponding .hpp file". In the case of your [comment above](https://github.com/openjdk/jdk/pull/27189#discussion_r2336167042) in this PR, the `.inline.hpp` file had a clear "corresponding `.hpp` file", namely `continuationEntry_x86.hpp`. 
>> 
>> Should the style guide state something like "the corresponding `.hpp` file for a `inline.hpp` whose name contains some compilation flag-dependent qualifier, is either the `.hpp` file with the qualifier (if present) or the `.hpp` file without the qualifier as a fallback" ?
>
>> There should be some more details about what constitutes the "corresponding .hpp file"
> 
> That's probably a good idea to further clarify what the "corresponding .hpp" file is, when arch (_x86) is included in the inline-file name. I also wonder what others think.

I'm going to open a PR with a small change in `style-guide.md` to start the discussion.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27189#discussion_r2343878101


More information about the hotspot-dev mailing list