RFR: 8367320: Sort cpu/x86 includes [v2]
Stefan Karlsson
stefank at openjdk.org
Fri Sep 12 13:15:28 UTC 2025
On Fri, 12 Sep 2025 11:11:10 GMT, Francesco Andreuzzi <fandreuzzi at openjdk.org> wrote:
>>> There should be some more details about what constitutes the "corresponding .hpp file"
>>
>> That's probably a good idea to further clarify what the "corresponding .hpp" file is, when arch (_x86) is included in the inline-file name. I also wonder what others think.
>
> I'm going to open a PR with a small change in `style-guide.md` to start the discussion.
Just note that we currently don't have a consistent way that we structure the inclusions of our the platform dependent files. When making the patch that followed the "corresponding .hpp" rule I had to handle the includes on case-by-case basis. Just be warned that you might create a rule that we can't adhere to without rewriting some of the includes patterns.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27189#discussion_r2344224871
More information about the hotspot-dev
mailing list