RFR: 8366905: Store AdapterBlob pointer in AdapterHandlerEntry [v3]

Andrew Dinn adinn at openjdk.org
Mon Sep 22 10:12:04 UTC 2025


On Fri, 19 Sep 2025 21:45:16 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:

>> This PR removes the need to store entry point addresses in AdapterHandlerEntry by storing a direct pointer to AdapterBlob instead. Entry point addresses can be computed on the fly from the entry point offsets stored in AdapterBlob.
>
> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add missing ResourceMark
>   
>   Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>

src/hotspot/share/oops/method.cpp line 1290:

> 1288:   } else if (_adapter == nullptr) {
> 1289:     (void) make_adapters(h_method, CHECK);
> 1290: #ifndef ZERO

With your change to sharedRuntime_zero.cpp I believe the preceding call to `make_adapters` will hit `ShouldNotReachHere()` and hence will not return. So, this #ifndef ZERO appears to be unnecessary.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27101#discussion_r2367420303


More information about the hotspot-dev mailing list