RFR: 8366905: Store AdapterBlob pointer in AdapterHandlerEntry [v3]
Andrew Dinn
adinn at openjdk.org
Mon Sep 22 10:41:49 UTC 2025
On Fri, 19 Sep 2025 21:45:16 GMT, Ashutosh Mehra <asmehra at openjdk.org> wrote:
>> This PR removes the need to store entry point addresses in AdapterHandlerEntry by storing a direct pointer to AdapterBlob instead. Entry point addresses can be computed on the fly from the entry point offsets stored in AdapterBlob.
>
> Ashutosh Mehra has updated the pull request incrementally with one additional commit since the last revision:
>
> Add missing ResourceMark
>
> Signed-off-by: Ashutosh Mehra <asmehra at redhat.com>
src/hotspot/share/runtime/sharedRuntime.hpp line 736:
> 734: }
> 735:
> 736: address get_i2c_entry() const { return _adapter_blob != nullptr ? _adapter_blob->i2c_entry() : nullptr; }
Should these getters assert `_adapter_blob != nullptr`?
I think we should only ever have an AdapterHandlerEntry with a null blob on ZERO and in that case an attempt to use the entry would be invalid.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27101#discussion_r2367566558
More information about the hotspot-dev
mailing list