RFR: 8366948: AOT cache creation crashes when iterating training data

[Ioi Lam]

On Wed, 24 Sep 2025 01:18:54 GMT, Igor Veresov <iveresov at openjdk.org> wrote:

> I forgot a lock around `CTD::_ci_records`. It also has to respect the snapshotting protocol. Testing is good.

src/hotspot/share/oops/trainingData.hpp line 606:

> 604:         TrainingDataLocker l;
> 605:         if (l.can_add()) {
> 606:           _data.append_if_missing(Record(result, ArgumentsType(args...)));

This calls `DepList<E>::append_if_missing()`. Should we add an `TrainingDataLocker::assert_locked()` in that function? I see many functions in this header file have this assert.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27461#discussion_r2373874663