RFR: 8366948: AOT cache creation crashes when iterating training data [v2]

[Igor Veresov]

On Wed, 24 Sep 2025 02:18:09 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> Igor Veresov has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Make DepList more defensive against non-MT-safe use
>
> src/hotspot/share/oops/trainingData.hpp line 606:
> 
>> 604:         TrainingDataLocker l;
>> 605:         if (l.can_add()) {
>> 606:           _data.append_if_missing(Record(result, ArgumentsType(args...)));
> 
> This calls `DepList<E>::append_if_missing()`. Should we add an `TrainingDataLocker::assert_locked()` in that function? I see many functions in this header file have this assert.

This is a very good idea. I sprinkled it around the public DepList functions and retested.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27461#discussion_r2376590553