RFR: 8367692: RISC-V: Align post call nop [v5]

[Robbin Ehn]

On Fri, 26 Sep 2025 13:25:14 GMT, Hamlin Li <mli at openjdk.org> wrote:

>> Robbin Ehn has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Use relocation spec as marker.
>
> src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp line 1353:
> 
>> 1351: 
>> 1352: void LIR_Assembler::call(LIR_OpJavaCall* op, relocInfo::relocType rtype) {
>> 1353:   Assembler::IncompressibleScope scope(_masm);
> 
> Is an alignment needed here?

It's aligned:

void LIR_Assembler::emit_call(LIR_OpJavaCall* op) {
  verify_oop_map(op->info());
  
  // must align calls sites, otherwise they can't be updated atomically
  align_call(op->code());

> src/hotspot/cpu/riscv/c1_LIRAssembler_riscv.cpp line 1364:
> 
>> 1362: 
>> 1363: void LIR_Assembler::ic_call(LIR_OpJavaCall* op) {
>> 1364:   Assembler::IncompressibleScope scope(_masm);
> 
> Is an alignment needed here?

It's aligned:

void LIR_Assembler::emit_call(LIR_OpJavaCall* op) {
  verify_oop_map(op->info());
  
  // must align calls sites, otherwise they can't be updated atomically
  align_call(op->code());

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27467#discussion_r2382839036
PR Review Comment: https://git.openjdk.org/jdk/pull/27467#discussion_r2382839132