RFR: 8377777: Improve logging when rejecting assets from the AOT archive [v3]
María Arias de Reyna Domínguez
duke at openjdk.org
Fri Feb 13 12:22:51 UTC 2026
On Thu, 12 Feb 2026 17:20:02 GMT, Andrew Dinn <adinn at openjdk.org> wrote:
>> María Arias de Reyna Domínguez has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Showing full method signature on log message
>
> src/hotspot/share/oops/cpCache.cpp line 605:
>
>> 603:
>> 604: if (!AOTConstantPoolResolver::is_resolution_deterministic(src_cp, cp_index)) {
>> 605: if (log.is_enabled()) {
>
> This also needs to identify the method that has been linked via the CP entry. However, note that the linkage for field and indy entries is also checked and erased (in ConstantPoolCache methods `remove_resolved_field_entries_if_non_deterministic` and `remove_resolved_indy_entries_if_non_deterministic`) when `AOTConstantPoolResolver::is_resolution_deterministic` returns true. So, a log message should be added in those two cases but this time identifying the target field or target BSM.
If I understand it right, for indy and for fields, the only reason (right now) to be rejected is because they are not deterministic.
Is it worth an error message explaining that?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29690#discussion_r2803935670
More information about the hotspot-dev
mailing list